chore: add docker build arguments to Dockerfile.dev#5017
Merged
gacevicljubisa merged 1 commit intomasterfrom Mar 4, 2025
Merged
chore: add docker build arguments to Dockerfile.dev#5017gacevicljubisa merged 1 commit intomasterfrom
gacevicljubisa merged 1 commit intomasterfrom
Conversation
acha-bill
approved these changes
Mar 3, 2025
istae
approved these changes
Mar 3, 2025
Contributor
istae
left a comment
istae
left a comment
There was a problem hiding this comment.
since we do not have a means of automated testing this, pls post screenshots in the PR so we can verify that the changes are working 🙏
Member
Author
It was requested by @nugaon some time ago to build image using these flags (other then default values). This is just an improvement for cmd.
Also, here is the example cmd that uses default values (if not specified): |
janos
approved these changes
Mar 3, 2025
martinconic
approved these changes
Mar 4, 2025
nugaon
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Add support for build arguments (REACHABILITY_OVERRIDE_PUBLIC, BATCHFACTOR_OVERRIDE_PUBLIC) in Dockerfile and PLATFORM in Makefile.
make docker-buildcmd when needed to build docker image with REACHABILITY_OVERRIDE_PUBLIC and BATCHFACTOR_OVERRIDE_PUBLIC flags, and in case when we are deploying cluster usingbeelocalOpen API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):